vtk: add vtk-dicom module #317335
Open
vtk: add vtk-dicom module #317335
+23
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, gdcm depends on vtk, but at the same time it's used as a dependency for vtk-dicom... |
|
ok, it doesn't need vtk integration here. |
|
Result of 3 packages marked as broken and skipped:
4 packages failed to build:
73 packages built:
|
|
|
|
Also not sure if it should be enabled by default. I don't see it's being used a lot, but it doesn't break anything. |
bcdarwin
suggested changes
Aug 12, 2024
| @@ -48,6 +61,8 @@ in stdenv.mkDerivation { | |||
| GLUT | |||
| ] ++ optionals enablePython [ | |||
| python | |||
| ] ++ optionals enableVtkDicom [ | |||
| (gdcm.override { enableVTK = false; }) | |||
There was a problem hiding this comment.
maybe we should consider lifting this to e.g. all-packages.nix say by defining vtkWithGdcm or similar, but I think it's fine?
There was a problem hiding this comment.
It's vice versa, gdcmWithGtk. I have no preference, so can move it.
There was a problem hiding this comment.
I think it's probably fine here also?
wegank
added
the
2.status: merge conflict
|
soft bump |
|
Updated the MR with |
kurnevsky
force-pushed
the
vtk-dicom
branch
2 times, most recently
from
0bd079b to
26a32ab
Compare
ofborg
bot
removed
the
2.status: merge conflict
bcdarwin
reviewed
Dec 16, 2024
bcdarwin
reviewed
Dec 16, 2024
bcdarwin
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add https://github.com/dgobbi/vtk-dicom module. It is needed for https://github.com/eidelen/DicomToMesh
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.